Skip to content

Use open_ASCII_file for sum output#193

Merged
Hallberg-NOAA merged 1 commit into
NOAA-GFDL:dev/gfdlfrom
marshallward:ascii_sum_output
May 26, 2023
Merged

Use open_ASCII_file for sum output#193
Hallberg-NOAA merged 1 commit into
NOAA-GFDL:dev/gfdlfrom
marshallward:ascii_sum_output

Conversation

@marshallward
Copy link
Copy Markdown
Member

@marshallward marshallward commented Apr 3, 2023

The generic open_file call was replaced with the targeted open_ASCII_file function, since the generic open_file no longer works with the updated FMS2 open_file interface in MOM6.

@kshedstrom
Copy link
Copy Markdown
Contributor

kshedstrom commented Apr 3, 2023

How about this one?

//import/c1/AKWATERS/kate/ESMG/ESMG-configs/src/SIS2/src/SIS_dyn_cgrid.F90:2271:78:

                      form=ASCII_FILE, threading=MULTIPLE, fileset=SINGLE_FILE)
                                                                              1
Error: Type mismatch in argument ‘io_handle’ at (1); passed INTEGER(4) to TYPE(file_type)

I think it's pointing to SINGLE_FILE

@marshallward
Copy link
Copy Markdown
Member Author

marshallward commented Apr 3, 2023

I tested against FMS1 🤦 thanks @kshedstrom.

@marshallward
Use open_ASCII_file for sum output
5348dea 
The generic open_file call was replaced with the targeted
open_ASCII_file function, since the generic open_file no longer works
with the updated FMS2 open_file interface in MOM6.
@kshedstrom
Copy link
Copy Markdown
Contributor

kshedstrom commented Apr 3, 2023

I now approve this PR. So the open_file in SIS_restart.F90 must not be a problem.

@marshallward
Copy link
Copy Markdown
Member Author

marshallward commented Apr 4, 2023

I now approve this PR. So the open_file in SIS_restart.F90 must not be a problem.

That's right, the restart file is still on the infra (FMS) layer, so the existing open_file interface ought to work.

Hallberg-NOAA
Hallberg-NOAA approved these changes May 17, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look sensible to me, and Kate has tested them thoroughly. This still needs to pass the pipeline testing (which is down at the moment due a series of ill-conceived "upgrades" to the Gaea computer), but once that testing is done, this should be merged into the dev/gfdl branch of SIS2.

@raphaeldussin
Copy link
Copy Markdown
Contributor

raphaeldussin commented May 22, 2023

I ran into this issue trying to compile with FMS2, +1 on this PR!

@marshallward
Copy link
Copy Markdown
Member Author

marshallward commented May 22, 2023

Sorry, we will get this in very soon once the CI has been reincarnated.

@Hallberg-NOAA
Copy link
Copy Markdown
Member

Hallberg-NOAA commented May 26, 2023

This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/SIS2/-/pipelines/19301.

@Hallberg-NOAA Hallberg-NOAA merged commit 31ada54 into NOAA-GFDL:dev/gfdl May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hallberg-NOAA Hallberg-NOAA Hallberg-NOAA approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marshallward @kshedstrom @raphaeldussin @Hallberg-NOAA